chore: Allow second token integration tests #233
Conversation
github-actions
bot
added
the
t-tooling
Pijukatel
force-pushed
the
allow-second-token-integration-tests
branch
from
7f5a886 to
1558750
Compare
Pijukatel
force-pushed
the
allow-second-token-integration-tests
branch
from
1558750 to
ba97150
Compare
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Could we choose a name that emphasizes the purpose of this token rather than just calling it "second token"? APIFY_MULTIUSER_TEST_TOKEN? APIFY_SHARED_STORAGE_TEST_USER_TOKEN?
I am not sure about it. The workflow repo is very generic. It is the downstream repos that decide what they use the env vars for. I would rather keep it as generic as possible here. Generic usecase is for example that this can be used not for multiuser tests or permissions test, but for tests that require different account settings than the usual test user has. |
|
Random thought, feel free to ignore it if you already thought about it - couldn't the first token be used to create a secondary user account that would be deleted at the end of the test suite? EDIT: it couldn't, there is no API endpoint that would allow this |
There was a problem hiding this comment.
I am not sure about it. The workflow repo is very generic. It is the downstream repos that decide what they use the env vars for. I would rather keep it as generic as possible here. Generic usecase is for example that this can be used not for multiuser tests or permissions test, but for tests that require different account settings than the usual test user has.
Ok, thanks, let's merge it then
### Description - Update integration tests to create storage of the second user on the fly - Added token for test user with id: `RbWKSZSutvaNWffdJ` under this secret `APIFY_TEST_USER_2_API_TOKEN`. This test user has restricted permissions. ### Issues - Closes: #542 - Requires: apify/workflows#233
To allow testing of multi-user test cases, such as sharing restricted access storage with another user.
Previously, such storage was permanently created, and thus user token was not needed. Someone from the organization deleted those storages :-(
So this setup was fragile, and we need to have the other token to create such storages on the fly.
Required by: apify/apify-client-python#543